Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS audio session allowing other audio to mix #6457

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Dec 15, 2024

We never want other audio to mix with the game. I've reconfigured the BASS setting to not touch audio session in general and leave it to our iOS project instead, as there is already existing code in there to configure the audio session when a user presses volume up/down, so it's better to have everything there instead of making BASS do it.

The SoloAmbient category should do the job, it respects the ring/silent switch and is not mixable with other audio.

@frenzibyte frenzibyte self-assigned this Dec 15, 2024
@peppy peppy merged commit aa8e72e into ppy:master Dec 16, 2024
14 checks passed
@frenzibyte frenzibyte deleted the ios-fix-mixing branch December 16, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminate music upon entering lazer on mobile.
2 participants